azure: encode storage account in azureblob:// URLs#18260
Open
hakman wants to merge 1 commit intokubernetes:masterfrom
Open
azure: encode storage account in azureblob:// URLs#18260hakman wants to merge 1 commit intokubernetes:masterfrom
hakman wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/test pull-kops-e2e-azure-cni-cilium |
hakman
force-pushed
the
azure-embed-st-account
branch
from
1a19654 to
a5d6563
Compare
Member
Author
|
/test pull-kops-e2e-azure-cni-cilium |
Move the Azure storage account name from the AZURE_STORAGE_ACCOUNT env
var into the URL so each azureblob:// path is self-contained. New
format: azureblob://{account}/{container}/{key}.
The env var is no longer read by kops; the legacy URL form is rejected
with a migration error pointing users at the new shape.
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
hakman
force-pushed
the
azure-embed-st-account
branch
from
a5d6563 to
acf08f5
Compare
Member
Author
|
/test pull-kops-e2e-azure-cni-cilium |
Member
Author
|
All tests are green now. |
Member
Author
|
/test all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Azure storage account name from the AZURE_STORAGE_ACCOUNT env var into the URL so each azureblob:// path is self-contained. New format: azureblob://{account}/{container}/{key}.
The env var is no longer read by kops; the legacy URL form is rejected with a migration error pointing users at the new shape.
/cc @rifelpet @justinsb