Skip to content

VPA: Add observedGeneration to status and conditions#9524

Open
adrianmoisey wants to merge 3 commits intokubernetes:masterfrom
adrianmoisey:add-observedGeneration
Open

VPA: Add observedGeneration to status and conditions#9524
adrianmoisey wants to merge 3 commits intokubernetes:masterfrom
adrianmoisey:add-observedGeneration

Conversation

@adrianmoisey
Copy link
Copy Markdown
Member

@adrianmoisey adrianmoisey commented Apr 20, 2026

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Doing to VPA what Jordan suggested we do to HPA: kubernetes/kubernetes#138228 (comment)

This also moves us closer to the standardised conditions: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1623-standardize-conditions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does a change like this need feature gateing? I assume not since it has a CRD that gets applied to the cluster.

Does this PR introduce a user-facing change?

VPA now stores a observedGeneration in both status and condition fields.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt April 20, 2026 18:08
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/vertical-pod-autoscaler Issues or PRs related to the Vertical Pod Autoscaler component labels Apr 20, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 20, 2026

This issue is currently awaiting triage.

If SIG Autoscaling contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2026
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 20, 2026

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@adrianmoisey
Copy link
Copy Markdown
Member Author

adrianmoisey commented Apr 27, 2026

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Apr 27, 2026
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2026
@adrianmoisey adrianmoisey force-pushed the add-observedGeneration branch from 06d2eb5 to e69e6d4 Compare April 28, 2026 18:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2026
@adrianmoisey
Copy link
Copy Markdown
Member Author

adrianmoisey commented Apr 28, 2026

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2026
omerap12
omerap12 reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit.
/lgtm
/hold

Comment thread vertical-pod-autoscaler/test/integration/recommender/recommender_test.go
Comment on lines +136 to +139
vpa, err := vpaClient.AutoscalingV1().VerticalPodAutoscalers(ns.Name).Get(ctx, vpaCRD.Name, metav1.GetOptions{})
if err != nil {
return false, err
}
Copy link
Copy Markdown
Member

@omerap12 omerap12 Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to retry here as well?

Copy link
Copy Markdown
Member Author

@adrianmoisey adrianmoisey Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt Awaiting requested review from liggitt

1 more reviewer

@omerap12 omerap12 omerap12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@omerap12 omerap12

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler Issues or PRs related to the Vertical Pod Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

API Reviews
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adrianmoisey @k8s-ci-robot @k8s-triage-robot @omerap12