Fix sample-config YAML quoting and refresh documentation#714
Fix sample-config YAML quoting and refresh documentation#714saripurigopi wants to merge 1 commit into
Conversation
|
This issue is currently awaiting triage. If prometheus-adapter contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @saripurigopi! |
|
Hi @saripurigopi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saripurigopi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fix double-quoted metricsQuery values in sample-config.yaml and config.md that caused YAML parse errors. Update config-walkthrough and walkthrough docs for accuracy.
9fe3bc1 to
d36abfd
Compare
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
What this PR does / why we need it
Fixes YAML parse errors in
docs/sample-config.yamlcaused by double-quotedmetricsQueryvalues containing inner double quotes (fixes #697).Updates configuration documentation for accuracy and clarity (fixes #679):
Which issue(s) this PR fixes
Fixes #697
Fixes #679
Special notes for your reviewer
Documentation-only change. Verified
docs/sample-config.yamlparses with PyYAML.