Fix: Use metric server full name instead of name for clusterrole in helm chart

[yesdeepakverma]

**This PR fixes the cluster role name to use helm chart full name instead of just the name which is default to metric-server **:

Almost all the resource except the APIService resource uses the (include "metrics-server.fullname" .) to generate the resources names . The cluster in fix is only used to be aggregated to upstream admin/edit/viewer role as per the annotation specified in the cluster role.
As per https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L375 and https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L396 and https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/policy.go#L386, any role having these annotation will be aggregated to admin/edit/view role

Fixes #

1. Use the fullname instead of name for cluster role .

This fix will help using the same naming convention as other resources in helm chart. This further will help users who have been managing the metric-server chart locally and wants to switch to upstream public helm chart for metric server. this will helm then install the helm chart without uninstalling the metric server chart first .

helm template command used to generate before and after the changes:

helm template my-release ./metrics-server

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yesdeepakverma
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: yesdeepakverma / name: Deepak Verma (7a3c3ca)

[k8s-ci-robot]

Welcome @yesdeepakverma!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @yesdeepakverma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yangjunmyfm192085]

/ok-to-test
/cc @stevehipwell

[yangjunmyfm192085]

/retest

[dgrisonnet]

/triage accepted
/assign @stevehipwell

[yesdeepakverma]

Looking for feedback. Let me know if something is required from my side.

[yesdeepakverma]

Hi @stevehipwell - please take a look.