Skip to content

fix: allow user to customize certificate issuer group in case of existingIssuer is enabled#1797

Open
maintux-nn wants to merge 1 commit into
kubernetes-sigs:masterfrom
maintux-nn:fix/cert-manager-group
Open

fix: allow user to customize certificate issuer group in case of existingIssuer is enabled#1797
maintux-nn wants to merge 1 commit into
kubernetes-sigs:masterfrom
maintux-nn:fix/cert-manager-group

Conversation

@maintux-nn

@maintux-nn maintux-nn commented May 5, 2026

Copy link
Copy Markdown

Fixes #1798

This pull request enhances the configuration options for specifying an existing cert-manager issuer in the Metrics Server Helm chart. The main improvement is the addition of a new parameter to allow users to set the issuer's group, which increases flexibility for advanced cert-manager setups (e.g. aws-privateca-issuer which uses group awspca.cert-manager.io).

Enhancements to cert-manager issuer configuration:

  • Added a new group field under tls.certManager.existingIssuer in values.yaml to allow specifying the group of the existing cert-manager issuer.
  • Updated the documentation in README.md to describe the new tls.certManager.existingIssuer.group parameter and its usage.
  • Modified the certificate.yaml template to use the new group value when configuring the issuer, ensuring the correct group is set for cert-manager resources.

@linux-foundation-easycla

linux-foundation-easycla Bot commented May 5, 2026

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: maintux-nn / name: Massimo Maino (0c298d5)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maintux-nn
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @maintux-nn!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @maintux-nn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Instrumentation May 5, 2026
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 5, 2026
@maintux-nn maintux-nn force-pushed the fix/cert-manager-group branch from f53f9ad to 0c298d5 Compare May 6, 2026 13:32

@stevehipwell stevehipwell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @maintux-nn, could you please add a CHANGELOG entry.

@github-project-automation github-project-automation Bot moved this from Needs Triage to In Progress in SIG Instrumentation May 15, 2026
@stevehipwell

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2026
@maintux-nn maintux-nn force-pushed the fix/cert-manager-group branch from 0c298d5 to b7d9365 Compare May 19, 2026 09:15
@maintux-nn

Copy link
Copy Markdown
Author

Thanks for the PR @maintux-nn, could you please add a CHANGELOG entry.

Hi @stevehipwell, CHANGELOG updated. Thanks

@maintux-nn maintux-nn requested a review from stevehipwell May 29, 2026 06:59
@dgrisonnet

Copy link
Copy Markdown
Member

/assign @stevehipwell
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 4, 2026
@maintux-nn

Copy link
Copy Markdown
Author

Hello @stevehipwell, any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

helm: cert-manager issuer group hardcoded to cert-manager.io breaks external issuers (e.g. aws-privateca-issuer)

4 participants