fix: allow user to customize certificate issuer group in case of existingIssuer is enabled#1797
fix: allow user to customize certificate issuer group in case of existingIssuer is enabled#1797maintux-nn wants to merge 1 commit into
Conversation
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maintux-nn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @maintux-nn! |
|
Hi @maintux-nn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f53f9ad to
0c298d5
Compare
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for the PR @maintux-nn, could you please add a CHANGELOG entry.
|
/ok-to-test |
0c298d5 to
b7d9365
Compare
Hi @stevehipwell, CHANGELOG updated. Thanks |
|
/assign @stevehipwell |
|
Hello @stevehipwell, any news? |
Fixes #1798
This pull request enhances the configuration options for specifying an existing cert-manager issuer in the Metrics Server Helm chart. The main improvement is the addition of a new parameter to allow users to set the issuer's group, which increases flexibility for advanced cert-manager setups (e.g.
aws-privateca-issuerwhich uses groupawspca.cert-manager.io).Enhancements to cert-manager issuer configuration:
groupfield undertls.certManager.existingIssuerinvalues.yamlto allow specifying the group of the existing cert-manager issuer.README.mdto describe the newtls.certManager.existingIssuer.groupparameter and its usage.certificate.yamltemplate to use the newgroupvalue when configuring the issuer, ensuring the correct group is set for cert-manager resources.