chore(helm): Add location to set hostUsers#1751
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jcpunk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If metrics-server contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @jcpunk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jcpunk have you opened an issue to discuss the viability of this? CC @serathius |
|
I don't have an issue open. I figured setting it to |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
stevehipwell
left a comment
There was a problem hiding this comment.
Thanks for you PR @jcpunk, I've suggested some changes. Please could you also update the README and add a CHANGELOG entry.
This defaults to the current kubernetes default and omits the flag on versions which may not have the feature. Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
|
Merged the changes in and squashed to one commit |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
/remove-lifecycle rotten |
What this PR does / why we need it:
Currently there is no place in helm to note if you want to try this out using user namespaces. This PR adds a flag where folks can start to experiment with user namespaces and metrics-server.
This defaults to the current kubernetes default and omits the flag on versions which may not have the feature.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #