Skip to content

go.mod: bump golang.org/x/tools to v0.26.0#31

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
marquiz:devel/golang-125
Oct 7, 2025
Merged

go.mod: bump golang.org/x/tools to v0.26.0#31
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
marquiz:devel/golang-125

Conversation

@marquiz

@marquiz marquiz commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Minimal version bump to make logcheck buildable with golang 1.25.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 10, 2025
@k8s-ci-robot

k8s-ci-robot commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If logtools contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Instrumentation Sep 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2025
@marquiz
go.mod: bump golang.org/x/tools to v0.26.0
95fb962 
Minimal version bump to make logcheck buildable with golang 1.25.
@marquiz

marquiz commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

/assign @pohly

@marquiz

marquiz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

ping @pohly

@marquiz

marquiz commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

/assign @serathius

pohly
pohly approved these changes Oct 7, 2025
View reviewed changes

@pohly pohly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@github-project-automation github-project-automation Bot moved this from Needs Triage to In Progress in SIG Instrumentation Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot

k8s-ci-robot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit d35c84c into kubernetes-sigs:main Oct 7, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in SIG Instrumentation Oct 7, 2025
@marquiz marquiz deleted the devel/golang-125 branch October 7, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly pohly approved these changes
@serathius serathius Awaiting requested review from serathius

Assignees

@pohly pohly

@serathius serathius

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Instrumentation
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marquiz @k8s-ci-robot @pohly @serathius