Adding tester for kube-burner

[vishnuchalla]

Description

Adding kube-burner tester for the purpose of CI. As per the plan here

Testing

Will be testing this in integration with kubernetes/kops#18371

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishnuchalla
Once this PR has been reviewed and has the lgtm label, please assign jbpratt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @vishnuchalla!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vishnuchalla. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[serathius]

Adding kube-burner tester for the purpose of CI. As per the plan here

Was the plan presented to SIG-scalability and approved? I don't see any reviewers or comments.

/cc @wojtek-t

[k8s-ci-robot]

@serathius: GitHub didn't allow me to request PR reviews from the following users: wojtek-t.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Adding kube-burner tester for the purpose of CI. As per the plan here

Was the plan presented to SIG-scalability and approved?

/cc @wojtek-t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pohly]

Why does this tester need to be added and maintained here? Could it be maintained by those who use it in some other repo instead of the owners of this repo (SIG Testing)?

[vishnuchalla]

Why does this tester need to be added and maintained here? Could it be maintained by those who use it in some other repo instead of the owners of this repo (SIG Testing)?

Just trying to keep it consistent with kubetest2 caller from kops similar to what we have for clusterloader2. But open to other suggestions too.

[vishnuchalla]

@mengqiy @upodroid PTAL 👋🏼

[pohly]

Just trying to keep it consistent with kubetest2 caller from kops

Exactly - that cluster tester is not maintained in the kubetest2 repo.

[aojea]

cluster tester

echoing Patrick comment, is there any reason if this is going to be used only with kops it can not be maintained there?

are plans to use it outside of kops? if that is the case, who is going to maintain it?

[upodroid]

hey, thank you for this change.

I recommend you use the exec tester and close this PR for a couple of reasons:

1. the kubeconfig is always set, and there is exactly 1 cluster in it in CI, kube-burner should be inferring it from the correct lcoations by default
2. the current flags are not really doing anything special that you can't do with exec

Here is a good example: https://github.com/kubernetes/kops/blob/master/tests/e2e/scenarios/metrics-server/run-test.sh