Skip to content

Fix typo: succesful -> successful in prompt test description#9

Open
SAY-5 wants to merge 2 commits into
kubernetes-sigs:masterfrom
SAY-5:fix-typo-succesful
Open

Fix typo: succesful -> successful in prompt test description#9
SAY-5 wants to merge 2 commits into
kubernetes-sigs:masterfrom
SAY-5:fix-typo-succesful

Conversation

@SAY-5

@SAY-5 SAY-5 commented May 10, 2026

Copy link
Copy Markdown

Corrects the misspelling 'succesful' to 'successful' in a Ginkgo test description.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2026
@k8s-ci-robot k8s-ci-robot requested review from brancz and dashpole May 10, 2026 23:50
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If instrumentation-tools contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @SAY-5!

It looks like this is your first PR to kubernetes-sigs/instrumentation-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/instrumentation-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@github-project-automation github-project-automation Bot moved this to Needs Triage in SIG Instrumentation May 10, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2026
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@SAY-5 SAY-5 force-pushed the fix-typo-succesful branch from d8abc5b to 78b5f6b Compare May 27, 2026 04:54

@dashpole dashpole left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation Bot moved this from Needs Triage to In Progress in SIG Instrumentation May 28, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, SAY-5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2026
@SAY-5

SAY-5 commented May 31, 2026

Copy link
Copy Markdown
Author

Could you add ok-to-test? CI is gated on it for new contributors.

@dashpole

dashpole commented Jun 1, 2026

Copy link
Copy Markdown

I don't think thats the issue. CI seems generally broken.

Error: The actions actions/setup-go@v2.1.0 and actions/checkout@v2 are not allowed in kubernetes-sigs/instrumentation-tools because all actions must be pinned to a full-length commit SHA.

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@SAY-5

SAY-5 commented Jun 11, 2026

Copy link
Copy Markdown
Author

You're right, that was the real blocker. Pushed ffa9eab pinning checkout and setup-go to full-length SHAs (v4.2.2 and v5.2.0) so they pass the org policy, and bumped go-version from 1.14 to 1.22 since the module is already on go 1.17. Dropped the stale ACTIONS_ALLOW_UNSECURE_COMMANDS env that only the old setup-go needed. go test -race ./promq/... is green locally.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants