Mirror Application.status.conditions verbatim on HelmRelease#25
Merged
Conversation
Argo CD surfaces real-world failures (chart pulled but repo unknown, malformed Application spec, sync errors, shared/orphaned/excluded resource warnings, ...) as entries in `Application.status.conditions[]`. Until now fargocd only mirrored the sync code and health code, so users had to fetch the Application themselves to see the actual cause. Mirror each Argo CD condition onto the HelmRelease verbatim, alongside the existing Ready/Reconciling pair: - Type = ApplicationCondition.Type (e.g. ComparisonError) - Status = True (presence == active) - Reason = ApplicationCondition.Type (verbatim, no rewriting) - Message = ApplicationCondition.Message - LastTransitionTime = Argo's LastTransitionTime, or now if unset Now `kubectl describe helmrelease foo` shows the underlying problem without a second hop. Add a fake-client test covering both an Argo CD warning and an error condition. Design.md updated to document the new behaviour and the corresponding "Future work" bullet removed. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argo CD surfaces real failures (chart pulled but repo unknown, malformed Application spec, sync errors, shared/orphaned/excluded resource warnings, ...) as entries in `Application.status.conditions[]`. Until now fargocd only mirrored the sync code and the health code, so users had to fetch the Application themselves to see the actual cause.
This PR mirrors each Argo CD condition onto the HelmRelease verbatim, alongside the existing Ready/Reconciling pair.
Mapping
Why
So `kubectl describe helmrelease foo` shows the underlying problem without a second hop into the Application. Closes the corresponding entry in Design.md "Future work".
What changed
Test plan