plan, controller: drop noisy INFO endpoint dumps; use ErrorS#82
Merged
Conversation
createAndApplyPlan logged the entire desired/current endpoint slices at
INFO every reconcile. At any non-trivial zone size this is large,
unstructured, and includes target IPs we don't need in steady-state
operator logs. Emit a structured one-line summary at V(2) with counts,
and keep the full dump at V(4) for debugging.
Same file: replace klog.Error(err.Error()) and klog.Errorln(err) with
klog.ErrorS so the structured logger gets a real "err" field instead
of stringified output, and add a short message for each failure site.
In the controller, klog.Error("failed to build controller.", err.Error())
was passing two args to a function that takes variadic interfaces —
losing the structured "err" field. Switch to klog.ErrorS.
Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan