cmds: scope scheme and setupLog inside NewCmdRun#78
Open
tamalsaha wants to merge 1 commit into
Open
Conversation
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
scheme and setupLog were package-level vars but were only ever used by NewCmdRun. Move them inside the function; AddToScheme calls move from init() into the constructor so the package no longer has init-time side effects. Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
force-pushed
the
refactor/scope-cmds-vars
branch
from
34fcfcc to
b90d56b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`scheme` and `setupLog` were package-level vars but were only used inside `NewCmdRun`. Move them inside the function; `AddToScheme` calls move from `init()` into the constructor so the package no longer has init-time side effects.
Test plan