controller: flush status once per Reconcile pass#71
Open
tamalsaha wants to merge 1 commit into
Open
Conversation
A single happy-path reconcile used to issue 4-5 PatchStatus calls (one per intermediate condition, one for DNSRecords, one for the terminal phase). Each call was a separate GET+PATCH and a separate UPDATE event on watchers. Replace updateEdnsStatus / patchDNSRecords with a statusUpdate accumulator that records conditions, phase, and DNSRecords as the reconciler progresses, and one patchStatus call that flushes everything on exit. SetCondition is still per-condition inside the patch closure, so the final on-server condition list is identical to the previous behavior. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A happy-path reconcile used to issue 4-5 PatchStatus calls — one per intermediate condition, one for DNSRecords, one for the terminal phase. Each was a separate GET+PATCH and a separate UPDATE event on watchers.
Replace `updateEdnsStatus` / `patchDNSRecords` with a `statusUpdate` accumulator that records conditions, phase, and DNSRecords as the reconciler progresses, plus one `patchStatus` call that flushes everything on exit. SetCondition is still per-condition inside the patch closure, so the final server-side condition list is identical.
Test plan