controller: scope the reconcile mutex onto the reconciler#68
Open
tamalsaha wants to merge 1 commit into
Open
Conversation
The package-level `var mutex sync.Mutex` made the lock implicit and ungrep-able. Move it onto ExternalDNSReconciler as `reconcileMu` and document the real reason it exists: the credential layer mutates process-wide env vars and well-known on-disk paths, so two reconciles for different providers cannot run concurrently today. No behavior change. The doc comment names the followup needed before we can bump MaxConcurrentReconciles. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The serialization lock used by `Reconcile` and `handleDeletion` lived as a package-level `var mutex sync.Mutex`. Moving it onto `ExternalDNSReconciler` makes its scope obvious and lets the doc comment record why it exists in the first place — the credential layer mutates process-wide env vars and well-known disk paths.
No behavior change. This is the small refactor that paves the way for plumbing per-resource credentials through and dropping the lock entirely.
Test plan