credentials: reset all provider env vars before configuring a new one#67
Merged
Conversation
Each provider-specific setter cleared only its own env vars (and setAzureCredential cleared none). When a user switched the provider on an ExternalDNS — or deleted one resource and created another with a different provider — stale credentials from the previous provider stayed in the process env. Combined with the per-process credential model, this made cross-provider transitions fragile. Centralize the reset in SetCredential so every provider env var we know about is unset before any provider setter runs. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
Signed-off-by: Tamal Saha <tamal@appscode.com>
Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each provider's credential setter reset only its own env vars (and Azure reset none). Switching providers across reconciles — or deleting one ExternalDNS and creating another with a different provider — would leave stale credentials from the previous provider in the process env.
This change centralizes the env reset in `SetCredential` so every known provider env var (AWS / GCP / Cloudflare) is unset before any per-provider setter runs.
Test plan