fix(runtimes): implement JAX reserved environment variable validation in Validate()#3670
Open
AdeshDeshmukh wants to merge 1 commit into
Open
fix(runtimes): implement JAX reserved environment variable validation in Validate()#3670AdeshDeshmukh wants to merge 1 commit into
AdeshDeshmukh wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… in Validate() Signed-off-by: Adesh Deshmukh <adeshkd123@gmail.com>
d76a25a to
a878529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The JAX plugin
sValidate()method atpkg/runtime/framework/plugins/jax/jax.go:52-54was previously a no-op (return nil, nil). This allowed users to manually setJAX_NUM_PROCESSES,JAX_PROCESS_ID, orJAX_COORDINATOR_ADDRESSin their TrainJobstrainer.env. When the controller runsEnforceMLPolicy, it silently overwrites these user-provided values viaapply.UpsertEnvVars, leading to hard-to-debug training failures.All other ML policy plugins (Torch, MPI, XGBoost) validate and reject TrainJobs that set reserved environment variables. This PR brings JAX to the same standard by:
JAXEnvNumProcesses,JAXEnvProcessID, andJAXEnvCoordinatorAddressconstants and aJAXReservedEnvNamesset inpkg/constants/constants.gosValidate()method that checks for reserved envs and returnsfield.Invalid` errors, following the exact pattern used by the Torch pluginWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #3669
Checklist: