Skip to content

Pass context to the utility methods in e2e tests#516

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
mimowo:pass-context-in-e2e-tests
Feb 6, 2023
Merged

Pass context to the utility methods in e2e tests#516
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
mimowo:pass-context-in-e2e-tests

Conversation

@mimowo

@mimowo mimowo commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

This is a follow up PR to cleanup the recently touched utility methods in e2e tests.

See for context: #511 (comment).

@alculquicondor alculquicondor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mimowo

mimowo commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

/assign @terrytangyuan

@terrytangyuan terrytangyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 31d4575 into kubeflow:master Feb 6, 2023
@mimowo mimowo deleted the pass-context-in-e2e-tests branch March 18, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants