Skip to content

chore: add CI and community hygiene#3

Merged
google-oss-prow[bot] merged 18 commits into
kubeflow:mainfrom
abhijeet-dhumal:ci/community-hygiene
Jun 24, 2026
Merged

chore: add CI and community hygiene#3
google-oss-prow[bot] merged 18 commits into
kubeflow:mainfrom
abhijeet-dhumal:ci/community-hygiene

Conversation

@abhijeet-dhumal

@abhijeet-dhumal abhijeet-dhumal commented Apr 9, 2026

Copy link
Copy Markdown
Member

Fixes #8

Hardens CI and community workflows before feature work continues.
Inspired from repo : https://github.com/kubeflow/sdk

@google-oss-prow google-oss-prow Bot added the do-not-merge/work-in-progress Work in progress label Apr 9, 2026
@google-oss-prow google-oss-prow Bot added size/XXL and removed size/XL labels Apr 9, 2026
@google-oss-prow google-oss-prow Bot added size/XL and removed size/XXL labels Apr 9, 2026
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review April 13, 2026 13:35
@google-oss-prow google-oss-prow Bot removed the do-not-merge/work-in-progress Work in progress label Apr 13, 2026
@abhijeet-dhumal abhijeet-dhumal marked this pull request as draft April 15, 2026 13:45
@google-oss-prow google-oss-prow Bot added size/L and removed size/XXL labels Apr 17, 2026
@abhijeet-dhumal abhijeet-dhumal marked this pull request as ready for review April 17, 2026 17:33
@google-oss-prow google-oss-prow Bot removed the do-not-merge/work-in-progress Work in progress label Apr 17, 2026
@abhijeet-dhumal abhijeet-dhumal marked this pull request as draft April 17, 2026 17:49
@google-oss-prow google-oss-prow Bot added the do-not-merge/work-in-progress Work in progress label Apr 17, 2026
@google-oss-prow google-oss-prow Bot added size/XL and removed size/L labels May 11, 2026
…lates with sdk

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
@abhijeet-dhumal

abhijeet-dhumal commented May 20, 2026

Copy link
Copy Markdown
Member Author

Hey @andreyvelich @kramaranya @kubeflow/kubeflow-sdk-team , are we good to ship this one ?

Comment thread .github/ISSUE_TEMPLATE/bug_report.yaml Outdated
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR enhances repository engineering productivity by updating local developer tooling (uv/ruff/pre-commit/Makefile), tightening CI workflows, and adding GitHub automation for labels, stale issues, dependabot updates, and contribution templates.

Changes:

  • Reworked Makefile targets around uv (install/dev sync, lint/format, expanded test/coverage, cleanup).
  • Added/updated GitHub automation (label sync, stale bot, PR title checks, welcome messages, workflow approvals, dependabot).
  • Refreshed repo hygiene/config (pre-commit hooks, .gitignore, issue/PR templates, contributing docs, minor markdown cleanup).

Reviewed changes

Copilot reviewed 17 out of 20 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pyproject.toml Adjusts dependency grouping layout (dev group under [dependency-groups]).
kubeflow_mcp/trainer/resources/training-patterns.md Removes trailing whitespace/blank line at EOF.
Makefile Expands/organizes dev, quality, test, and cleanup targets using uv.
LICENSE Normalizes final line numbering/formatting (no semantic content change).
CONTRIBUTING.md Expands allowed Conventional Commit “Types”.
.pre-commit-config.yaml Adds basic hooks and updates Ruff hooks/config.
.gitignore Broadens ignored artifacts (coverage, envs, uv, notebooks, OS files).
.github/workflows/welcome-new-contributors.yaml Adds first-interaction automation for issues/PRs.
.github/workflows/test-python.yaml Adds pip-audit job; uses setup-uv@v4 in tests.
.github/workflows/sync-labels.yaml Adds workflow to sync labels from .github/labels.yml.
.github/workflows/github-stale.yaml Adds stale issue/PR management workflow.
.github/workflows/gh-workflow-approve.yaml Adds workflow-run approval automation gated by ok-to-test.
.github/workflows/check-pr-title.yaml Switches to pull_request_target and expands semantic title rules.
.github/labels.yml Introduces canonical label set for sync workflow.
.github/dependabot.yml Adds Dependabot config for “uv” and GitHub Actions ecosystems.
.github/PULL_REQUEST_TEMPLATE.md Updates PR template to include related issue/testing/sign-off checklist.
.github/ISSUE_TEMPLATE/feature_request.yaml Updates feature request template and labels.
.github/ISSUE_TEMPLATE/config.yml Adds contact links / issue template config.
.github/ISSUE_TEMPLATE/bug_report.yaml Updates bug report template and labels/required fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread .github/workflows/gh-workflow-approve.yaml
Comment thread .pre-commit-config.yaml Outdated
Comment thread .github/workflows/sync-labels.yaml Outdated
Comment thread .github/dependabot.yml Outdated
…5409 and PYSEC-2026-161

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
…n verify/format

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
- dependabot.yml: change package-ecosystem from "uv" to "pip" — uv is
  not a supported Dependabot ecosystem; pip correctly reads pyproject.toml
- .pre-commit-config.yaml: rename hook id ruff-check → ruff — ruff-check
  is not a valid hook id in astral-sh/ruff-pre-commit; correct ids are
  ruff (lint) and ruff-format
- sync-labels.yaml: pin third-party actions to immutable commit SHAs
  (actions/checkout@v4.3.1, EndBug/label-sync@v2) for supply-chain hardening
- gh-workflow-approve.yaml: already filters by head_sha client-side — no change needed

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Comment thread .github/ISSUE_TEMPLATE/config.yml Outdated
Comment thread .github/workflows/check-pr-title.yaml Outdated
Comment thread .github/workflows/check-pr-title.yaml Outdated
Comment thread .github/workflows/welcome-new-contributors.yaml
Comment thread pyproject.toml
Comment on lines +57 to +58
"idna>=3.15", # CVE-2026-45409
"starlette>=1.0.1", # PYSEC-2026-161

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

@abhijeet-dhumal abhijeet-dhumal Jun 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this PR adds security pip-audit checks
And the above pinned versions resolves known CVEs detected by pip-audit, but I have made sure to keep it outside direct dependencies

But I'm happy to tweak it if there is any other standard format to resolve this issues!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace pip-audit with osv-scanner in a follow-up which is used in Kubeflow-SDK's implementation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created issue for follow up here : #29

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>
@abhijeet-dhumal

Copy link
Copy Markdown
Member Author

Hey @kramaranya @andreyvelich , I have addressed all the above reviews , are we good to launch ?

@abhijeet-dhumal

Copy link
Copy Markdown
Member Author

Hey @kramaranya @andreyvelich , I have addressed all the above reviews , are we good to launch ?

@andreyvelich @kramaranya Is there anything remaining for this PR, May I request your review here!

@kramaranya kramaranya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhijeet-dhumal!
/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm Looks good to me — approved by a reviewer label Jun 24, 2026

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added the approved Approved by an approver in OWNERS label Jun 24, 2026
@google-oss-prow google-oss-prow Bot merged commit 888cee2 into kubeflow:main Jun 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved by an approver in OWNERS lgtm Looks good to me — approved by a reviewer size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI pipelines, labels, and community hygiene

6 participants