feat(backend): support KALE_PYPI_PROD_URL for configurable production PyPI index#866
Open
Bhavd33p wants to merge 1 commit into
Open
feat(backend): support KALE_PYPI_PROD_URL for configurable production PyPI index#866Bhavd33p wants to merge 1 commit into
Bhavd33p wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
… PyPI index Air-gapped or mirror-only deployments can't reach pypi.org, but Kale always appended it as the hardcoded production fallback in generated pipeline components regardless of other pip index overrides. Add KALE_PYPI_PROD_URL so this fallback is configurable, defaulting to https://pypi.org/simple for backward compatibility. Fixes kubeflow#797 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: [Bhavdeep Singh] <bhavdeep3singh@gmail.com>
Bhavd33p
force-pushed
the
feat/kale-pypi-prod-url
branch
from
29ab69c to
b35cadb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_pip_index_urls()hardcoded the production pip index fallback tohttps://pypi.org/simple, appended unconditionally regardless ofKALE_PIP_INDEX_URLS/KALE_DEV_MODEoverridesKALE_PYPI_PROD_URLenv var to make this fallback configurable, defaulting tohttps://pypi.org/simplefor backward compatibilityKALE_PIP_*/KALE_DEV_MODEvars indocs/source/user-guide/running-pipelines.mdanddocs/source/api/cli.mdFixes #797
Test plan
pytest kale/tests/unit_tests/test_utils.py -k compute_pip_index_urls -v— 8 passed (5 existing + 3 new)pytest kale/tests/unit_tests/— 247 passedKALE_PYPI_PROD_URLset → used in place ofpypi.org; unset → falls back tohttps://pypi.org/simple🤖 Generated with Claude Code