fix: improve ANSI regex, add short-string guard, add debug logging in rm_r#864
Closed
Kaibalya-Mohanty wants to merge 9 commits into
Closed
fix: improve ANSI regex, add short-string guard, add debug logging in rm_r#864Kaibalya-Mohanty wants to merge 9 commits into
Kaibalya-Mohanty wants to merge 9 commits into
Conversation
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Reverted unintended function renaming and implementation changes. Kept only the docstring improvements for remove_ansi_color_sequences. Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
Reverted broader ANSI regex, removed isinstance check, removed early-return guard in shorten_long_string, and removed added log.debug call in rm_r. Signed-off-by: KAIBALYA MOHANTY <168870673+Kaibalya-Mohanty@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Kaibalya-Mohanty
changed the title
Collaborator
|
hi @Kaibalya-Mohanty this PR is the same as https://github.com/kubeflow/kale/pull/704/changes , please close this one. |
Member
|
This PR don't bring too much value for Kale so I'm closing it. feel free to check something in our roadmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates the behavioral changes from PR #704 (docs-only).
Changes:
escape sequences, added isinstance check to handle non-string input safely.
shorter than chars * 2 to avoid unnecessary slicing.
easier debugging.