Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Add importing yaml library on mnist_e2e_on_prem.ipynb (#553)#555

Open
kwonmha wants to merge 2 commits into
kubeflow:masterfrom
kwonmha:master
Open

Add importing yaml library on mnist_e2e_on_prem.ipynb (#553)#555
kwonmha wants to merge 2 commits into
kubeflow:masterfrom
kwonmha:master

Conversation

@kwonmha

@kwonmha kwonmha commented Mar 25, 2021

Copy link
Copy Markdown

What this PR does / why we need it:
Added missing import yaml statement.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #553

Special notes for your reviewer:

Let me know if I should add release notes.

Release note:


@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kwonmha
To complete the pull request process, please assign jinchihe after the PR has been reviewed.
You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xauthulei xauthulei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwonmha , you missed the \n, please have try. Thanks

@xauthulei xauthulei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here miss the \n

@kwonmha

kwonmha commented Mar 26, 2021

Copy link
Copy Markdown
Author

Thx @xauthulei .
Added \n.

@xauthulei

Copy link
Copy Markdown
Member

/lgtm

@jinchihe , it seems the Travis CI have some issue, would you check it please. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

name 'yaml' is not defined

3 participants