fix(examples): correct broken config paths in cityscapes singletask_learning_bench#582
Conversation
kubeedge-bot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: karanthengane23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/M
karanthengane23
force-pushed
the
fix-cityscapes-singletask-paths
branch
from
75c6303 to
a7fa39f
Compare
kubeedge-bot
removed
the
do-not-merge/invalid-commit-message
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a README and updates configuration paths for the Cityscapes semantic segmentation single-task learning benchmark, aligning them under the new semantic-segmentation directory structure. Additionally, it renames the dataset configuration keys in testenv.yaml from train_url/test_url to train_index/test_index. The only feedback is to add a trailing newline to the end of testenv.yaml to comply with POSIX standards.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…earning_bench benchmarkingjob.yaml, testenv.yaml, and rfnet_algorithm.yaml referenced each other without the semantic-segmentation/ directory segment the files actually live under, so `ianvs -f` failed immediately with RuntimeError: not found testenv config file. testenv.yaml also used train_url/test_url dataset keys, which core/testenvmanager/dataset/dataset.py does not recognize (only train_index/train_data/train_data_info are checked), causing NotImplementedError even after the path fix. Renamed to train_index/test_index, matching the working pcb-aoi example. Verified with `ianvs -f examples/cityscapes/singletask_learning_bench/semantic-segmentation/benchmarkingjob.yaml`: now progresses cleanly past config loading and dataset key parsing, failing only on the Cityscapes dataset files not being present locally (expected - same as any example, the dataset must be downloaded separately). Also added a README documenting the dataset source, expected index file format, and run instructions, since the example previously had none. Signed-off-by: Karan Thengane <karanthengane23@gmail.com>
karanthengane23
force-pushed
the
fix-cityscapes-singletask-paths
branch
from
a7fa39f to
fe045a0
Compare
|
/assign @MooreZheng |
3 participants
/kind bug
What this PR does / why we need it:
examples/cityscapes/singletask_learning_bench/semantic-segmentationhad two independent bugs that blocked execution before any model/data code ran:benchmarkingjob.yaml,testenv.yaml, andrfnet_algorithm.yamlreferenced each other without thesemantic-segmentation/directory segment that the files actually live under. Running the example failed immediately with:testenv.yaml's dataset section usedtrain_url/test_urlkeys, whichcore/testenvmanager/dataset/dataset.pydoes not recognize (it only checkstrain_index/train_data/train_data_info). Even after fixing (1), this caused:train_index/test_index, matching the convention used in the workingpcb-aoiexample.Also added a
README.mdfor this example (it previously had none), documenting the Cityscapes dataset source, expected index-file format, the model checkpoint requirement, and run instructions.Verification: ran
ianvs -f examples/cityscapes/singletask_learning_bench/semantic-segmentation/benchmarkingjob.yamlafter each fix. It now progresses cleanly past all config-loading and dataset-key-parsing stages, failing only on the Cityscapes dataset files not being present locally — expected, since the dataset must be downloaded separately (same as any other example).Which issue(s) this PR fixes:
Fixes #581