fix: add missing requirements.txt for federated-llm example#576
fix: add missing requirements.txt for federated-llm example#57631groot wants to merge 2 commits into
Conversation
Signed-off-by: Parv Agrawal <agrawalparv13@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 31groot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces a requirements.txt file for the federated LLM example, specifying core dependencies such as torch, transformers, peft, and evaluate. The feedback highlights a missing dependency, rouge_score, which is required by the evaluate library's ROUGE metric and should be added to prevent runtime import errors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| peft>=0.4.0 | ||
| tqdm>=4.65.0 | ||
| numpy>=1.24.0 | ||
| evaluate>=0.4.0 |
There was a problem hiding this comment.
Signed-off-by: Parv Agrawal <agrawalparv13@gmail.com>
|
/assign @jaypume |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
federated-llmexample had norequirements.txt, causing contributorsto hit
ModuleNotFoundErrorwith no guidance. Added dependencies basedon actual imports in
model.py,FedAvg-PEFT.py, andFedAvgM-PEFT.py.Dependencies added: torch, transformers, peft, tqdm, numpy, evaluate.
Which issue(s) this PR fixes:
Fixes #563