fix: add missing requirements.txt for government_rag and llm_simple_qa examples#571
fix: add missing requirements.txt for government_rag and llm_simple_qa examples#57131groot wants to merge 2 commits into
Conversation
…a examples Signed-off-by: Parv Agrawal <agrawalparv13@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 31groot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces requirements.txt files for the government_rag and llm_simple_qa examples. The feedback highlights that numpy and requests are missing from the government_rag requirements, which are necessary to prevent ModuleNotFoundError during execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| torch>=2.0.0 | ||
| transformers>=4.30.0 | ||
| langchain>=0.1.0 | ||
| langchain-community>=0.0.20 | ||
| chromadb>=0.4.0 | ||
| tqdm>=4.65.0 | ||
| unstructured[docx]>=0.10.0 |
There was a problem hiding this comment.
The government_rag example's basemodel.py imports numpy at the top level (line 26) and uses requests in the default qianfan model response method (line 118). To prevent ModuleNotFoundError when running this example, both numpy and requests should be added to the requirements.txt file.
torch>=2.0.0
transformers>=4.30.0
numpy>=1.24.0
requests>=2.28.0
langchain>=0.1.0
langchain-community>=0.0.20
chromadb>=0.4.0
tqdm>=4.65.0
unstructured[docx]>=0.10.0
Signed-off-by: Parv Agrawal <agrawalparv13@gmail.com>
|
/assign @MooreZheng |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
government_ragandllm_simple_qaexamples had norequirements.txt,this causes new contributors to hit
ModuleNotFoundErrorwith no guidanceon what to install. Both
llm-agentandllm-edge-benchmark-suitealready have requirements.txt, this brings the remaining LLM examples
to the same standard.
Added dependencies based on actual imports found in each example's
basemodel.py and algorithm files.
Which issue(s) this PR fixes:
Fixes #563