Skip to content

Fix module loading path collision #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avinxshKD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix module loading path collision #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions core/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,13 @@

"""This script contains some common tools."""

import hashlib
import importlib
import os
import sys
import time

from importlib import import_module
from importlib import import_module, util
from inspect import getfullargspec
import yaml

Expand Down Expand Up @@ -92,12 +93,28 @@ def yaml2dict(url):
def load_module(url):
"""Load python module."""
module_path, module_name = os.path.split(url)
loaded_module = None
if os.path.isfile(url):
module_name = module_name.split(".")[0]

sys.path.insert(0, module_path)
try:
importlib.import_module(module_name)
sys.path.pop(0)
if os.path.isfile(url):
module_id = hashlib.md5(os.path.abspath(url).encode("utf-8")).hexdigest()
module_name = f"{module_name}_{module_id}"
if module_name not in sys.modules:
spec = util.spec_from_file_location(module_name, url)
if spec is None or spec.loader is None:
raise ImportError(f"not found module spec({module_name})")
mod = util.module_from_spec(spec)
sys.modules[module_name] = mod
loaded_module = module_name
spec.loader.exec_module(mod)
else:
importlib.import_module(module_name)
except Exception as err:
if loaded_module:
sys.modules.pop(loaded_module, None)
raise RuntimeError(f"load module(url={url}) failed, error: {err}") from err
finally:
sys.path.pop(0)