fix: update deprecated torchvision make_grid API and resolve DataLoader worker import failures#555
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fahmid-Arman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates make_grid calls in summaries.py to use value_range instead of range and sets the default number of workers to 0 in args.py. The reviewer recommends making the number of workers configurable via kwargs instead of hardcoding it to 0 to avoid bottlenecking training performance.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…er worker import failures Signed-off-by: Fahmid Arman <fahmid.brac@gmail.com>
3e9211c to
58e7ed5
Compare
|
Feedback addressed:
/assign @jaypume |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The ERFNet training pipeline crashed on modern Python environments due to two separate execution failures involving deprecated APIs and subprocess module imports.
rangekeyword argument tovalue_rangeacross alltorchvision.utils.make_grid()calls inutils/summaries.pyto restore compatibility withtorchvision >= 0.8.0.self.workers = 0withinTrainArgsinutils/args.pyto force PyTorchDataLoaderto run in the main process. This prevents worker subprocesses from crashing withModuleNotFoundErrordue to lostsys.pathmodifications.Which issue(s) this PR fixes:
Fixes #472