fix(#92,#93,#203): validate channel names, improve empty-state copy, and add agent guide#217
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs-rustchat-io | b967a5e | Commit Preview URL Branch Preview URL |
Jul 06 2026, 02:55 PM |
- Add server-side validation for channel names in v4 create_channel: non-empty, <= 64 chars, lowercase letters/numbers/hyphens/underscores. - Add integration test covering empty, whitespace-only, over-long and invalid-character names, plus a valid-name regression guard. - Replace the sidebar 'No channels' placeholder with friendly copy that explains no channels exist and points users to create or browse. Signed-off-by: zoorpha <aaron@kubedo.com>
zoorpha
force-pushed
the
fix/channel-validation-empty-state
branch
from
30c2043 to
6179a0d
Compare
senolcolak
previously approved these changes
Jul 6, 2026
- Create canonical root AGENTS.md with repo map, validation commands, and AI-agent change boundaries. - Link README.md and CONTRIBUTING.md to AGENTS.md. - Add docs/agent-guides/README.md as a thin index to existing guides. - Deprecate docs/internal/AGENTS.md in favor of the root file. Signed-off-by: zoorpha <aaron@kubedo.com>
zoorpha
changed the title
senolcolak
previously approved these changes
Jul 6, 2026
- Replace relative ../../AGENTS.md links with absolute GitHub URLs so Vitepress no longer reports dead links when building the docs site. - Update agent-model.md links from rustchatio/rustchat to kubedoio/rustchat. Signed-off-by: zoorpha <aaron@kubedo.com>
senolcolak
previously approved these changes
Jul 6, 2026
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3d29a1b60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Trim the channel name before validating and pass the normalized value to ChannelRepository::create so whitespace-padded valid names are stored without leading/trailing spaces instead of falling through to the DB unique constraint. - Add integration-test assertion that whitespace-padded names return 200 and are stored trimmed. Signed-off-by: zoorpha <aaron@kubedo.com>
senolcolak
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92, closes #93, closes #203.
Backend (#92)
validate_channel_name()inbackend/src/api/v4/channels/crud.rsand calls it fromcreate_channel." trimmed-channel "returns 200 and is stored as"trimmed-channel".create_channel_rejects_invalid_namesinbackend/tests/api_v4_channels_all.rscovering empty, whitespace-only, over-long and invalid-character names (all 400), plus a valid-name regression guard (200).Frontend (#93)
Contributor / Agent Workflow (#203)
AGENTS.mdwith repo map, CI-aligned validation commands, and AI-agent change boundaries.README.mdandCONTRIBUTING.mdtoAGENTS.md.docs/agent-guides/README.mdas a thin index to existing guides.docs/internal/AGENTS.mdin favor of the root file.Verification
cargo test --test api_v4_channels_allpasses.cargo fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warnings, andcargo test --libpass.npm run docs:check-links,npm run docs:check-config, andnpm run docs:buildpass.