remove features from k8s-openapi dependency#74
Open
orangecms wants to merge 1 commit into
Open
Conversation
Library crates must not enable k8s-openapi features. The eventual app/operator needs to be able to select their own version. See <https://github.com/Arnavion/k8s-openapi/blob/b2c839b8b1828e9035ff8467cdac87756190aa4e/src/lib.rs#L75>. For CI, use the `K8S_OPENAPI_ENABLED_VERSION` env var. Signed-off-by: Jiji Freya Daniel Maslowski <daniel.maslowski@rise-world.com>
52ef1e7 to
52d29fb
Compare
Contributor
Author
|
Oh well, that quick attempt gets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library crates must not enable k8s-openapi features. The eventual app/operator needs to be able to select their own version.
See https://github.com/Arnavion/k8s-openapi/blob/b2c839b8b1828e9035ff8467cdac87756190aa4e/src/lib.rs#L75.
resolves #73