알림에 BigTextStyle 적용#730
Merged
Merged
Conversation
Contributor
개요알림 빌더에 변경 사항알림 스타일링 개선
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core/util/src/test/java/com/ku_stacks/ku_ring/util/KuringNotificationManagerTest.kt`:
- Around line 10-16: KuringNotificationManagerTest uses JUnit4; migrate it to
JUnit5 by replacing the import org.junit.Test with org.junit.jupiter.api.Test,
swap the class-level `@RunWith`(RobolectricTestRunner::class) for
`@ExtendWith`(RobolectricExtension::class) and add the import
org.robolectric.junit5.RobolectricExtension, and keep using shadowOf(...) as
needed; also ensure the android-junit5 plugin is enabled and the JUnit5 (6.0.3)
test dependency bundle is configured so the test class
(KuringNotificationManagerTest) compiles and runs under JUnit5.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e14f114c-1b0a-4b66-a009-3c62fe04ee40
📒 Files selected for processing (2)
core/util/src/main/java/com/ku_stacks/ku_ring/util/KuringNotificationManager.ktcore/util/src/test/java/com/ku_stacks/ku_ring/util/KuringNotificationManagerTest.kt
Comment on lines
+10
to
+16
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.robolectric.RobolectricTestRunner | ||
| import org.robolectric.Shadows.shadowOf | ||
|
|
||
| @RunWith(RobolectricTestRunner::class) | ||
| class KuringNotificationManagerTest { |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# JUnit4/JUnit5 사용 현황 및 설정 점검 (읽기 전용)
set -euo pipefail
echo "== 테스트 코드에서 JUnit4/JUnit5 및 Robolectric 사용 패턴 확인 =="
rg -n --type=kt 'import org\.junit\.Test|import org\.junit\.runner\.RunWith|`@RunWith`\(|import org\.junit\.jupiter\.api\.Test|RobolectricTestRunner|RobolectricExtension'
echo
echo "== Gradle 설정에서 JUnit/Jupiter/Robolectric 의존성 확인 =="
fd -i 'build.gradle*' | xargs rg -n 'junit|jupiter|robolectric'Repository: ku-ring/KU-Ring-Android
Length of output: 164
🏁 Script executed:
#!/bin/bash
# Check the actual content of the test file in question
echo "== Content of KuringNotificationManagerTest.kt =="
cat -n core/util/src/test/java/com/ku_stacks/ku_ring/util/KuringNotificationManagerTest.kt
echo
echo "== JUnit4/JUnit5 imports across test files =="
rg -n 'import org\.junit\.' core/util/src/test/java --max-count=20
echo
echo "== Check for `@RunWith` and RobolectricTestRunner usage =="
rg -n '`@RunWith`|RobolectricTestRunner|RobolectricExtension' core/util/src/test/java --max-count=20
echo
echo "== Look for JUnit5 imports (jupiter) =="
rg -n 'import org\.junit\.jupiter' core/util/src/test/javaRepository: ku-ring/KU-Ring-Android
Length of output: 2776
🏁 Script executed:
#!/bin/bash
# Check build configuration for testing framework dependencies
echo "== Gradle build files in core/util =="
find core/util -name 'build.gradle*' -type f
echo
echo "== JUnit and testing framework dependencies in build.gradle files =="
find . -name 'build.gradle*' -type f -exec grep -l "junit\|jupiter\|robolectric" {} \;
echo
echo "== Root build.gradle content (testing dependencies) =="
cat build.gradle.kts 2>/dev/null | grep -A 50 "dependencies\|testImplementation" | head -100 || cat build.gradle 2>/dev/null | grep -A 50 "dependencies\|testImplementation" | head -100 || echo "No build.gradle found or readable"Repository: ku-ring/KU-Ring-Android
Length of output: 1499
🏁 Script executed:
#!/bin/bash
# Check core/util build configuration
echo "== core/util/build.gradle.kts content =="
cat core/util/build.gradle.kts
echo
echo "== Gradle version catalog (libs.versions.toml) =="
find . -name 'libs.versions.toml' -o -name 'versions.gradle.kts' | xargs cat 2>/dev/null | grep -A 5 -B 5 'junit\|robolectric' || echo "Not found or pattern not matched"Repository: ku-ring/KU-Ring-Android
Length of output: 4091
🏁 Script executed:
#!/bin/bash
# Check for gradle/libs.versions.toml
echo "== Looking for version catalog files =="
find . -type f \( -name '*.versions.toml' -o -name 'versions.gradle*' \) 2>/dev/null
echo
echo "== Check gradle directory structure =="
ls -la gradle/ 2>/dev/null || ls -la gradle.properties 2>/dev/null || echo "gradle directory not accessible"Repository: ku-ring/KU-Ring-Android
Length of output: 635
JUnit4 API 대신 JUnit5로 마이그레이션하세요.
현재 코드는 JUnit4의 org.junit.Test, @RunWith 등을 사용하고 있으나, 코딩 규약 **/*Test.kt에 따라 JUnit5 기반으로 통일해야 합니다.
프로젝트의 gradle/libs.versions.toml에 JUnit5(6.0.3)와 android-junit5 플러그인이 정의되어 있으므로, 다음과 같이 마이그레이션합니다:
import org.junit.Test→import org.junit.jupiter.api.Test@RunWith(RobolectricTestRunner::class)→@ExtendWith(RobolectricExtension::class)또는 플러그인 활성화 후 직접 사용
참고: 현재 프로젝트의 모든 테스트 파일이 JUnit4를 사용 중이므로, 이 파일의 수정은 프로젝트 전반적인 JUnit5 마이그레이션의 일부입니다. 빌드 설정의 android-junit5 플러그인 활성화와 unit-test 의존성 번들 수정도 함께 검토하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core/util/src/test/java/com/ku_stacks/ku_ring/util/KuringNotificationManagerTest.kt`
around lines 10 - 16, KuringNotificationManagerTest uses JUnit4; migrate it to
JUnit5 by replacing the import org.junit.Test with org.junit.jupiter.api.Test,
swap the class-level `@RunWith`(RobolectricTestRunner::class) for
`@ExtendWith`(RobolectricExtension::class) and add the import
org.robolectric.junit5.RobolectricExtension, and keep using shadowOf(...) as
needed; also ensure the android-junit5 plugin is enabled and the JUnit5 (6.0.3)
test dependency bundle is configured so the test class
(KuringNotificationManagerTest) compiles and runs under JUnit5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
테스트
Summary by CodeRabbit
릴리스 노트
New Features
Tests