インラインポップアップ(#, @)の項目をTab/矢印キーで選択可能にする#32
Merged
Conversation
ktmage
added a commit
that referenced
this pull request
Mar 1, 2026
ktmage
added a commit
that referenced
this pull request
Mar 1, 2026
THIRD_PARTY_NOTICES.md に react-icons (VS Code Icons subset) のライセンスを追加。 CHANGELOG の Unreleased に Keyboard navigation for inline popups と SVG アイコン置換を追記。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#(ファイル候補)や@(エージェント候補)入力時に表示されるインラインポップアップに、キーボードナビゲーションを追加しました。Closes #29
変更内容
キーボード操作
フォーカス管理
変更ファイル
UI層
ListItemにfocusedprop とdata-focused属性によるハイライトスタイルを追加HashFilePopup/AgentPopupにfocusedIndexprop を追加InputAreaにhashFocusedIndex/atFocusedIndex状態管理とキーボードハンドリングを追加テスト層
ListItem/HashFilePopup/AgentPopupの単体テストにフォーカス関連テストを追加21-popup-tab-select.test.tsxを新規作成(14テスト)