Implement PolicyService#61
Merged
Merged
Conversation
codekansas
reviewed
May 14, 2025
codekansas
left a comment
codekansas
left a comment
Member
There was a problem hiding this comment.
i see - so the idea is that the policy is stored locally under some uuid, and we can trigger it to start or stop? i think this makes sense, we should integrate this with the kscale api and pull and push models from there
codekansas
approved these changes
May 14, 2025
Contributor
Author
|
yes, in the current state, the uuid simply represents a local kinfer file. I like the idea of having models that can be pulled for the api! |
Contributor
Author
|
Can we merge this as it stands and plan for full kscale api integration in the near future? |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PolicyService is used to do the following:
Start Policy (kinfer filename, episode length, action scale)
Stop Policy
Get Policy State/Status
Currently tested and being used in kos-zbot