[DO NOT CLOSE] Shared Memory Logging#16
Draft
gitfish7 wants to merge 6 commits into
Draft
Conversation
gitfish7
commented
Jul 24, 2025
| ) -> std::io::Result<()> { | ||
| // drain the buffered events | ||
| while event::poll(Duration::from_millis(0))? { | ||
| if let event::Event::Key(key) = event::read()? { |
Contributor
Author
There was a problem hiding this comment.
this change should have been picked up by clippy earlier, not sure why it got missed
gitfish7
commented
Jul 24, 2025
| let mut batch_buf: Vec<u8> = Vec::with_capacity(BUF_SIZE); | ||
|
|
||
| while let Ok(evt) = rx.recv() { | ||
| // first receive random data |
Contributor
Author
There was a problem hiding this comment.
some cleanup needed :')
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sending data around is hard
Solution
We will use a pub sub style shared memory data transfer method. For now this will be used to log data to disk and nothing else. In the future, as we make everything into components. We will use the shared memory pathways to talk between componenents.
Notes