Skip to content

chore(Pagination): refactor and styling update#1080

Open
hebernardEquisoft wants to merge 15 commits into
masterfrom
dev/refactor-pagination
Open

chore(Pagination): refactor and styling update#1080
hebernardEquisoft wants to merge 15 commits into
masterfrom
dev/refactor-pagination

Conversation

@hebernardEquisoft

@hebernardEquisoft hebernardEquisoft commented Feb 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

DS-1296

Description

Ici on vient mettre à jour et améliorer la composante Pagination, tant sur le plan visuel que technique, afin de la rendre plus robuste, flexible et facile à maintenir.

Améliorations visuelles

  • Mise à jour du style pour la page sélectionnée : ajout d'un border et d'un font-weight.
  • Masquage des boutons de navigation lorsqu'ils sont disabled.
  • Suppression des marges et paddings par défaut, pour une meilleure intégration dans différents contextes.
  • Respect du layout et de la division des conteneurs, conformément à la maquette Figma.

Améliorations techniques:

  • Refactoring de la composante pour faciliter sa maintenance.
  • Mise en place d'un contexte pour centraliser la logique et améliorer la communication entre les sous-composantes.
  • Ajout de classes CSS sur les différentes sous-composantes pour améliorer l'accessibilité et la flexibilité de la customisation.
  • Exposition des PaginationProps pour permettre une utilisation plus complète et typée de la composante.

Tests fonctionnels

  • S'assurer que la composante est conforme à celle présenté dans Figma.

@hebernardEquisoft hebernardEquisoft requested a review from a team as a code owner February 4, 2025 12:55
@hebernardEquisoft hebernardEquisoft changed the title DS-1296 chore(Pagination): refactor and styling update chore(Pagination): refactor and styling update Feb 4, 2025
@github-actions

github-actions Bot commented Feb 4, 2025

Copy link
Copy Markdown

Storybook for this build: https://ds.equisoft.io/pr-1080/

@github-actions

github-actions Bot commented Feb 4, 2025

Copy link
Copy Markdown

Webapp for this build: https://ds.equisoft.io/pr-1080/webapp/

hebernardEquisoft and others added 3 commits February 4, 2025 08:22
@hebernardEquisoft
fix(Pagination): stylelint
c574366
@hebernardEquisoft
chore(Pagination): add babel file
df29f42
@renovate @hebernardEquisoft
deps(*): update react-router (#1075)
20c7d56 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mmorin-equisoft mmorin-equisoft self-assigned this Feb 4, 2025
LarryMatte
LarryMatte requested changes Feb 4, 2025
View reviewed changes

@LarryMatte LarryMatte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1ere passe de fait.

Comment thread packages/react/src/components/pagination/page-link/styled.ts Outdated
Comment thread packages/react/src/components/pagination/page-link/styled.ts Outdated
Comment thread packages/react/src/components/pagination/page-link/styled.ts Outdated
Comment thread packages/react/src/components/pagination/page-link/styled.ts Outdated
Comment thread packages/react/src/components/pagination/page-link/page-link.tsx Outdated
Comment thread packages/react/src/components/pagination/label/styled.ts Outdated
Comment thread packages/react/src/components/pagination/label/styled.ts Outdated
Comment thread packages/react/src/components/pagination/styled.ts Outdated
Comment thread packages/react/src/components/pagination/styled.ts Outdated
Comment thread packages/react/src/components/pagination/label/pagination-label.tsx Outdated
LarryMatte
LarryMatte requested changes Feb 11, 2025
View reviewed changes
Comment thread packages/react/src/components/pagination/buttons/page-button/pagination-page-button.tsx Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/pagination-page-button.tsx Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts Outdated
Comment thread packages/react/src/components/pagination/buttons/page-button/styled.ts
Comment thread packages/react/src/components/pagination/buttons/nav-button/pagination-nav-button.tsx Outdated
@mmorin-equisoft mmorin-equisoft changed the title chore(Pagination): refactor and styling update chore(Pagination): refactor and styling update Feb 12, 2025
@mmorin-equisoft mmorin-equisoft changed the title chore(Pagination): refactor and styling update chore(Pagination): refactor and styling update Feb 12, 2025
maboilard
maboilard approved these changes Feb 13, 2025
View reviewed changes

@maboilard maboilard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good pour le styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LarryMatte LarryMatte LarryMatte requested changes
@maboilard maboilard maboilard approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@mmorin-equisoft mmorin-equisoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hebernardEquisoft @LarryMatte @maboilard @mmorin-equisoft