Distinct allergen icons grouped by pollen source - #69
Merged
Conversation
mdi:barley reads as a cereal ear. The previous mdi:grain is Material Design Icons' film-grain icon, tagged for photography, which is why it looked like nothing in particular at sensor size. Requested in issue #63. Filed under a new 0.5.4 section: v0.5.3 is already published and stays as it is.
Nine distinct icons across twenty-two allergens made a sensor list hard to scan: seven allergens shared mdi:leaf, seven mdi:tree, and mugwort and ragweed shared mdi:flower-pollen with the fallback icon, so an allergen the integration does not recognize looked like either of them. Now thirteen, grouped by pollen source: catkin trees, broadleaf trees, evergreens, grasses, cereals, weeds, herbs and fungal spores. Hazel, plane tree, mugwort, ragweed and sorrel get an icon of their own, no allergen is left on the fallback icon, and fungal spores lose mdi:cloud-alert, which read as a system warning rather than a biological source. Material Design Icons has no species-specific plant icons -- no acorn, birch, olive or chestnut -- and fourteen of the allergens are trees, so the remaining shared icons are deliberate. A shared icon is better than one depicting the wrong plant. Every name was checked against the MDI catalogue.
The icon work ships as 0.5.4; v0.5.3 is published and stays as it is.
Owner
Author
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR updates the Home Assistant Polleninformation EU integration to use more distinct, source-grouped Material Design Icons for allergen sensors, improving scanability in entity/device lists, and bumps the integration version to 0.5.4.
Changes:
- Reworked
ALLERGEN_ICON_MAPto use 13 distinct icons grouped by pollen source (and changed rye tomdi:barley). - Bumped the integration manifest version to
0.5.4. - Added changelog notes describing the icon updates for v0.5.4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| custom_components/polleninformation/sensor.py | Updates allergen icon mapping to distinct, source-grouped MDI icons. |
| custom_components/polleninformation/manifest.json | Bumps integration version to 0.5.4. |
| CHANGELOG.md | Adds v0.5.4 changelog entry describing the icon changes. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The section was stamped with the day it was written, not the day 0.5.4 is expected to ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #68 (do not auto-close; the issue tracks the 0.5.4 release).
Icon improvements for all allergen sensors, spun off from feedback in #63:
mdi:grain→mdi:barley. The old icon is MDI's film-grain pattern (tagged Photography), not a cereal.mdi:tree-outline), deciduous trees (mdi:tree), conifer (mdi:pine-tree), evergreen olive (mdi:leaf-circle), plane tree (mdi:leaf-maple, its leaf is maple-like), hazel (mdi:hops, the catkin resembles a hop cone), grasses (mdi:grass), rye (mdi:barley), weeds (mdi:flowermugwort,mdi:flower-poppyragweed,mdi:sproutdock/sorrel), leafy herbs (mdi:leaf), fungal spores (mdi:mushroom).mdi:flower-pollen) anymore.MDI has no species-specific plant icons (no oak, birch, olive and so on), so meaningful groups beat arbitrary uniqueness. The groups roughly follow cross-reactivity. All 22 icon names are verified against the MDI catalog's meta.json. These icons only show in Home Assistant's own UI; pollenprognos-card uses its own icons and is unaffected.
Tests: full suite green (203 passed). The slug contract test is unaffected (it pins keys, not icon values).