feat: implement Android conversation notifications#3215
Draft
PolynomialDivision wants to merge 1 commit into
Draft
feat: implement Android conversation notifications#3215PolynomialDivision wants to merge 1 commit into
PolynomialDivision wants to merge 1 commit into
Conversation
PolynomialDivision
force-pushed
the
android-converstaions
branch
from
0f13158 to
5ac57b0
Compare
Add SHORTCUT_CATEGORY_CONVERSATION to room shortcuts and link per-room notification channels with setConversationId so MessagingStyle notifications appear in Android's Conversations section. Clean up shortcuts and channels on logout.
PolynomialDivision
force-pushed
the
android-converstaions
branch
from
5ac57b0 to
489f52c
Compare
krille-chan
reviewed
Jul 5, 2026
| * The shortcut intent format is kept compatible with flutter_shortcuts_new so | ||
| * that FlutterShortcuts().listenAction() in chat_list.dart continues to work. | ||
| */ | ||
| class ConversationNotifications(private val context: Context) : MethodChannel.MethodCallHandler { |
Owner
There was a problem hiding this comment.
I am not going to maintain Kotlin code. Cant we use a flutter plugin?
Owner
|
@PolynomialDivision have you used LLM to create this pr? |
krille-chan
reviewed
Jul 6, 2026
| if (PlatformInfos.isAndroid && messagingStyleInformation == null) { | ||
| await _setShortcut(event, l10n, title, roomAvatarFile); | ||
| if (PlatformInfos.isAndroid) { | ||
| await AndroidConversationNotifications.publishShortcut( |
Owner
There was a problem hiding this comment.
So looks like this is something which should instead be fixed in the flutter local notifications package and shortcut package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SHORTCUT_CATEGORY_CONVERSATION to room shortcuts and link per-room notification channels with setConversationId so MessagingStyle notifications appear in Android's Conversations section. Clean up shortcuts and channels on logout.
Pull Request has been tested on:
Fixes: #868