fix: preserve encrypted room mention notifications#3160
Open
PolynomialDivision wants to merge 1 commit into
Open
fix: preserve encrypted room mention notifications#3160PolynomialDivision wants to merge 1 commit into
PolynomialDivision wants to merge 1 commit into
Conversation
MSC4028 (push all encrypted events) is still experimental and disabled on most homeservers including matrix.org. Without it, a room-level mentions-only rule blocks all server pushes for encrypted events, since the server cannot inspect ciphertext to evaluate mention rules. The device never wakes up, so no mention notification reaches the user. To work around this, install a companion override push rule for each encrypted room in mentions-only mode. The override matches m.room.encrypted events server-side, waking the device. After decryption the event type changes, so the override no longer matches client-side and the room rule correctly filters out non-mentions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSC4028 (push all encrypted events) is still experimental and disabled on most homeservers including matrix.org. Without it, a room-level mentions-only rule blocks all server pushes for encrypted events, since the server cannot inspect ciphertext to evaluate mention rules. The device never wakes up, so no mention notification reaches the user.
To work around this, install a companion override push rule for each encrypted room in mentions-only mode. The override matches m.room.encrypted events server-side, waking the device. After decryption the event type changes, so the override no longer matches client-side and the room rule correctly filters out non-mentions.
Pull Request has been tested on: