feat: improve caption display for portrait images#3153
Open
PolynomialDivision wants to merge 1 commit into
Open
feat: improve caption display for portrait images#3153PolynomialDivision wants to merge 1 commit into
PolynomialDivision wants to merge 1 commit into
Conversation
If a portrait image has a caption, the text gets compressed to the width of the image which often looks bad. Expand to full bubble width and crop the image as a tradeoff. User needs to tap to see the full image.
Owner
But for a picture with very small width and large height this would look super bad and pixelated, right? |
Contributor
Author
I think it is not worse than before. A user needs to click on the image than... I think this is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a portrait image has a caption, the text gets compressed to the width of the image which often looks bad. Expand to full bubble width and crop the image as a tradeoff. User needs to tap to see the full image.
Pull Request has been tested on: