Skip to content

feat: improve caption display for portrait images#3153

Open
PolynomialDivision wants to merge 1 commit into
krille-chan:mainfrom
PolynomialDivision:crop-image-with-description
Open

feat: improve caption display for portrait images#3153
PolynomialDivision wants to merge 1 commit into
krille-chan:mainfrom
PolynomialDivision:crop-image-with-description

Conversation

@PolynomialDivision

Copy link
Copy Markdown
Contributor

If a portrait image has a caption, the text gets compressed to the width of the image which often looks bad. Expand to full bubble width and crop the image as a tradeoff. User needs to tap to see the full image.

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

If a portrait image has a caption, the text gets compressed to the
width of the image which often looks bad. Expand to full bubble width
and crop the image as a tradeoff. User needs to tap to see the full
image.
@krille-chan

Copy link
Copy Markdown
Owner

If a portrait image has a caption, the text gets compressed to the width of the image which often looks bad. Expand to full bubble width and crop the image as a tradeoff. User needs to tap to see the full image.

But for a picture with very small width and large height this would look super bad and pixelated, right?

@PolynomialDivision

Copy link
Copy Markdown
Contributor Author

But for a picture with very small width and large height this would look super bad and pixelated, right?

I think it is not worse than before. A user needs to click on the image than... I think this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants