Skip to content

feat: chat list for spaces#3040

Open
twoneis wants to merge 1 commit into
krille-chan:mainfrom
twoneis:space-chat-list
Open

feat: chat list for spaces#3040
twoneis wants to merge 1 commit into
krille-chan:mainfrom
twoneis:space-chat-list

Conversation

@twoneis

@twoneis twoneis commented May 29, 2026

Copy link
Copy Markdown
Contributor

Show the regular chat list for spaces and move the UI to join rooms in spaces to a separate screen.
Only small parts of the changes are actually new code, most of it is moving things from chat_list/space_view to space_rooms/{space_rooms.dart,space_rooms_view.dart} and rearranging stuff.

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

@twoneis twoneis requested a review from krille-chan as a code owner May 29, 2026 14:01
@twoneis twoneis force-pushed the space-chat-list branch from 77e2f50 to 3cb57a4 Compare May 29, 2026 14:22
@twoneis twoneis marked this pull request as draft May 29, 2026 14:24
@twoneis twoneis force-pushed the space-chat-list branch 2 times, most recently from 3e88f82 to d3891c6 Compare May 29, 2026 14:43
@twoneis twoneis marked this pull request as ready for review May 29, 2026 14:48
@twoneis

twoneis commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

Alright, botched rebase happened there, it should be ready for review now.

@twoneis twoneis force-pushed the space-chat-list branch 5 times, most recently from 982d398 to fe6f6b8 Compare May 29, 2026 16:38
@krille-chan

Copy link
Copy Markdown
Owner

Have you read the contribution guidelines?

https://github.com/krille-chan/fluffychat/blob/main/CONTRIBUTING.md#contributing-guidelines

For bigger or complex changes (more than a couple of code lines) write an issue or refer to an existing issue and ask for approval from the maintainers (@krille-chan) before starting to implement it. This way you reduce the risk that your Pull Request get's declined.

@twoneis

twoneis commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

I did read that but as I said it was mostly moving existing code around and not writing new code but reading it again I can see how it could be considered a big change. If you want me to write an additional issue with more motivation I can do so now; if you mean that it will be rejected either way because the design doesn't align with what you want fluffychat to be that would be fine by me too, as I said it was not as much work as it may seem and I would probably want to maintain this patch for myself either way.

@twoneis

twoneis commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Hi @krille-chan, do you think there is any way to move this forward or should I just close this?

Show the regular chat list for spaces and move the
UI to join spaces to a separate screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants