feat: chat list for spaces#3040
Conversation
3e88f82 to
d3891c6
Compare
|
Alright, botched rebase happened there, it should be ready for review now. |
982d398 to
fe6f6b8
Compare
|
Have you read the contribution guidelines? https://github.com/krille-chan/fluffychat/blob/main/CONTRIBUTING.md#contributing-guidelines
|
|
I did read that but as I said it was mostly moving existing code around and not writing new code but reading it again I can see how it could be considered a big change. If you want me to write an additional issue with more motivation I can do so now; if you mean that it will be rejected either way because the design doesn't align with what you want fluffychat to be that would be fine by me too, as I said it was not as much work as it may seem and I would probably want to maintain this patch for myself either way. |
|
Hi @krille-chan, do you think there is any way to move this forward or should I just close this? |
Show the regular chat list for spaces and move the UI to join spaces to a separate screen.
Show the regular chat list for spaces and move the UI to join rooms in spaces to a separate screen.
Only small parts of the changes are actually new code, most of it is moving things from
chat_list/space_viewtospace_rooms/{space_rooms.dart,space_rooms_view.dart}and rearranging stuff.Pull Request has been tested on: