feat: Add standard markdown shortcuts#2843
Conversation
| if (evt is KeyDownEvent && | ||
| (HardwareKeyboard.instance.isControlPressed || | ||
| HardwareKeyboard.instance.isMetaPressed) && | ||
| !PlatformInfos.isMobile) { |
There was a problem hiding this comment.
Why not enable this on mobile too? This would also block iPads with a keyboard or Samsung Dex or the new Android 16 desktop mode or other scenarios
There was a problem hiding this comment.
mostly because I didn't really think of it. Idrk anything about ipad/IOS qwq
There was a problem hiding this comment.
after looking at it, I think this would be handled by HardwareKeyboard.instance.isControlPressed which should work with those
| if (evt.logicalKey == LogicalKeyboardKey.keyY) { | ||
| undoController.redo(); | ||
| return KeyEventResult.handled; | ||
| } |
There was a problem hiding this comment.
Looks very handy. 🤔 Actually I would like to prefer having an integration test for this as well to make sure this never breaks. Is this possible on Android?
There was a problem hiding this comment.
it...should be...I think....I'll test it today 😅
|
@ION606 are you still going to work on this? CI is failing |
oh yea I forgot. Sure I can work on it tmw, ditto with the rest of them |
|
@ION606 formatting fails |
I'll try to get to it after work today qwq |
2 participants
Added standard markdown shortcuts to the chat (ctrl+i, ctrl+a, ctrl+b, etc)
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Pull Request has been tested on: