feat(video): add cross-platform video player support#2456
Open
RafayAhmad7548 wants to merge 1 commit into
Open
feat(video): add cross-platform video player support#2456RafayAhmad7548 wants to merge 1 commit into
RafayAhmad7548 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds cross-platform video player support to FluffyChat by integrating the media_kit library, enabling video playback on Windows and Linux desktop platforms where it was previously unsupported.
Key changes:
- Added media_kit dependencies for Linux and Windows desktop video playback
- Removed platform-specific video player checks, enabling video functionality across all platforms
- Initialized media_kit video player in the main entry point for desktop platforms
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Added media_kit dependencies for cross-platform video support |
| pubspec.lock | Added transitive and direct dependencies for media_kit ecosystem |
| windows/flutter/generated_plugins.cmake | Registered media_kit plugins for Windows build |
| windows/flutter/generated_plugin_registrant.cc | Added Windows plugin registration for media_kit |
| macos/Flutter/GeneratedPluginRegistrant.swift | Added macOS plugin registration for media_kit |
| linux/flutter/generated_plugins.cmake | Registered media_kit plugins for Linux build |
| linux/flutter/generated_plugin_registrant.cc | Added Linux plugin registration for media_kit |
| lib/utils/platform_infos.dart | Removed supportsVideoPlayer flag that limited video to mobile/web |
| lib/pages/image_viewer/video_player.dart | Removed conditional platform checks for video player initialization |
| lib/pages/image_viewer/image_viewer.dart | Removed conditional inclusion of video events based on platform |
| lib/pages/chat/events/video_player.dart | Removed platform-specific fallback behavior for video playback |
| lib/main.dart | Added media_kit initialization for Linux and Windows at app startup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RafayAhmad7548
force-pushed
the
video-support-desktop
branch
from
3c2eabf to
a5cdd1f
Compare
krille-chan
reviewed
Feb 1, 2026
| latlong2: ^0.9.1 | ||
| linkify: ^5.0.0 | ||
| matrix: ^4.1.0 | ||
| media_kit_libs_linux: ^1.2.1 |
Owner
There was a problem hiding this comment.
Has this been tested inside of a flatpak and a snap as well? Otherwise we cannot merge
Author
There was a problem hiding this comment.
I haven't done flatpak/snap testing.
I will test it and let you know.
Author
There was a problem hiding this comment.
I was able to test for flatpak and it works with some additions to the flatpak manifset.
wasn't able to test snap yet, will let you know when i do
krille-chan
added
the
stale
krille-chan
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issuse #1333
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Pull Request has been tested on: