Skip to content

fix: android share screen #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gibbz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: android share screen #2437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils/show_scaffold_dialog.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Future<T?> showScaffoldDialog<T>({
required Widget Function(BuildContext context) builder,
}) => showDialog<T>(
context: context,
useSafeArea: false,

@krille-chan krille-chan Dec 18, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does change it for all showScaffoldDialog uses. Have you checked all of them? Maybe better make this configurable, keep the default to false and only for the share screen make it true?

@Gibbz Gibbz Dec 18, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I'll have a dig and see what other dialogs are using it then test them.

@Gibbz Gibbz Dec 21, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the uses of this dialog. they are all working fine. There are several forwarding and sharing screens using it.
(image_viewer.dart, chat_list.dart, and chat.dart)

@Gibbz Gibbz Dec 21, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops not sure if i should use resolved or not

useSafeArea: true,
builder: FluffyThemes.isColumnMode(context)
? (context) => Center(
child: Container(
Expand Down