Conversation
Collaborator
|
It would be nice to structure the project (js and css folders for corresponding files). |
Collaborator
|
The layout of drops is broken for double-digit values |
Collaborator
Basic scope: 70Mark-up and design: 30
Basic game logic: 40
Advanced scope: 70
Hacker scope: 10
|
broshkabro
approved these changes
Feb 25, 2021
Comment on lines
+14
to
+38
| function draw() { | ||
| cnv.width = cnv.width; | ||
|
|
||
| for(let j = waves.length - 1; j >= 0; j--) { | ||
| let offset = i + j * Math.PI * 12; | ||
| ctx.fillStyle = (waves[j]); | ||
| let randomLeft = (Math.sin(offset/100) + 1) / 2 * 200; | ||
| let randomRight = (Math.sin((offset/100) + 10) + 1) / 2 * 200; | ||
| let randomLeftConstraint = (Math.sin((offset/60) + 2) + 1) / 2 * 200; | ||
| let randomRightConstraint = (Math.sin((offset/60) + 1) + 1) / 2 * 200; | ||
|
|
||
| ctx.beginPath(); | ||
| ctx.moveTo(0, randomLeft + 100); | ||
|
|
||
| ctx.bezierCurveTo(w / 3, randomLeftConstraint, w / 3 * 2, randomRightConstraint, w, randomRight + 100); | ||
| ctx.lineTo(w , h); | ||
| ctx.lineTo(0, h); | ||
| ctx.lineTo(0, randomLeft + 100); | ||
|
|
||
| ctx.closePath(); | ||
| ctx.fill(); | ||
| } | ||
|
|
||
| i = i + 3; | ||
| } |
Collaborator
There was a problem hiding this comment.
Please add code indentation inside this function and for-loop to improve the readability.
| flex-direction: column; | ||
| justify-content: center; | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
remove unnecessary empty lines
| // { | ||
| // sign: "/", | ||
| // operation: function(a,b){ return a / b; } | ||
| // } |
Collaborator
There was a problem hiding this comment.
if you are not going to use this code, then it is better to remove it.
|
|
||
| const removeElement = (element) => { | ||
| element.remove(); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.