Conversation
broshkabro
approved these changes
Apr 6, 2021
broshkabro
left a comment
broshkabro
left a comment
Collaborator
There was a problem hiding this comment.
Basic scope +30.
Advanced scope +30.
Bonus +20.
Comment on lines
+93
to
+94
| </div> | ||
| </div> |
| <div class="skill-item"> | ||
| <div class="icon"><img src="./img/icons8-javascript-96.png" alt="js_icon"></div> | ||
| <h2>JAVASCRIPT</h2> | ||
| <p>JavaScript is a programming language that conforms |
| </footer> | ||
| <script src="./app.js"></script> | ||
| </body> | ||
| </html> |
Collaborator
There was a problem hiding this comment.
Please mind the formatting. It is difficult to understand the hierarchy of the elements because of it.
| document.addEventListener('scroll', () => { | ||
| let scrollPosition = window.scrollY; | ||
| if (scrollPosition > 250) { | ||
| header.style.backgroundColor = '#29323c'; |
Collaborator
There was a problem hiding this comment.
It is better to use a constant for the color.
| const hamburger = document.querySelector('.header .nav-bar .nav-list .hamburger'); | ||
| const mobileMenu = document.querySelector('.header .nav-bar .nav-list ul'); | ||
| const header = document.querySelector('.header.container'); | ||
| const menuItem = document.querySelectorAll('.header .nav-bar .nav-list ul li a'); |
Collaborator
There was a problem hiding this comment.
It is better to use less specific selector classes.
Comment on lines
+744
to
+760
| #header .nav-list ul li { | ||
| display: inline-block; | ||
| } | ||
|
|
||
| #header .nav-list ul li a { | ||
| font-size: 1.8rem; | ||
| } | ||
|
|
||
| #header .nav-list ul a:after { | ||
| display: none; | ||
| } | ||
|
|
||
| #skills .skill-bottom .skill-item { | ||
| flex-basis: 22%; | ||
| margin: 1.5%; | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
You are using one of the strongest selectors - selector by id. It is hard to override it. You should think about less specific selectors, that are strong enough (like classes) and easy to override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.