Align default --steps/--cfg with recommended RAW settings (52 / 3.5)#1
Open
asciidiego wants to merge 1 commit into
Open
Align default --steps/--cfg with recommended RAW settings (52 / 3.5)#1asciidiego wants to merge 1 commit into
asciidiego wants to merge 1 commit into
Conversation
538ebc3 to
66c605c
Compare
fec2cf2 to
5378363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: default
--steps28→52 and--cfg4.5→3.5 ininference.py,sampling.py, and the README Options table.Why (grounded in this repo + internal decision):
oss_raw(inference.py--checkpoint default="oss_raw"), and this README's own RAW quickstart prescribes--steps 52 --cfg 3.5. The defaults (28 / 4.5) contradict our recommended RAW invocation, so a no-flag run produces a worse RAW result.Independent of the other PRs — merge or skip on its own. (Turbo is unaffected: it always passes explicit
--steps 8 --cfg 0.0.)