bcachefs: avoid SRCU-held data update allocations#730
Draft
Komzpa wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GFP_NOWAITafter dropping btree locksbch2_trans_unlock_long()before retrying withGFP_KERNELContext
This is a narrow follow-up to the SRCU/blocking-operation class discussed in koverstreet/bcachefs#1069 and reproduced again in koverstreet/bcachefs#1165.
The reported hangs show reconcile/copygc/writeback paths spending minutes with
reconcile_btree/sectors_allocactive and warnings frombch2_trans_unlock_long()about a transaction holding SRCU for too long.bch2_data_update_init()is one of the paths named in koverstreet/bcachefs#1069: it already drops btree locks before allocating the read/write bios for data update IO, but the old code still did the potentially reclaim-blockingGFP_KERNELallocation while the transaction SRCU read lock could remain held.This patch keeps the cheap path cheap by trying
GFP_NOWAITfirst. Only when that fails does it drop SRCU and retry withGFP_KERNEL.Related to koverstreet/bcachefs#1165, koverstreet/bcachefs#1069, #659, and #710.
Validation
git diff --checkBINDGEN=/home/kom/.cargo/bin/bindgen make -j32 build/fs/data/update.oBINDGEN=/home/kom/.cargo/bin/bindgen make -j32 bcachefs