btree: make write buffer flush waits SRCU-aware#705
Closed
Komzpa wants to merge 1 commit into
Closed
Conversation
Owner
|
Merged — cherry-picked onto master (bdf3476, authorship preserved). The unlock_long→unlock is required for trans_wait_event to have SRCU to manage, and it's safe: the only thing now running under the held SRCU read lock, fetch_wb_keys_from_journal(), is bounded (buf_lock + write-buffer lock + in-memory key copying — no indefinite wait or journal disk IO), and the actual unbounded wait is the SRCU-aware trans_wait_event. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
btree_write_buffer_flush_seq()currently drops the transaction SRCU read lock immediately withbch2_trans_unlock_long()before waiting for write-buffer pins to drain.Switch that wait to the existing SRCU-aware
trans_wait_event()pattern:bch2_trans_unlock()for the fast path;write_buffer_flush_waitthroughtrans_wait_event();This is a narrow companion to the broader SRCU/blocking-wait discussion in koverstreet/bcachefs#1069. It follows the maintainer-requested shape there without doing another blanket
unlock_long()conversion.Validation
git diff --checkmake generate_versionBINDGEN=/home/kom/.cargo/bin/bindgen make -j32 fs/btree/write_buffer.oBINDGEN=/home/kom/.cargo/bin/bindgen make -j32 bcachefs