Conversation
- Correct auto-policy handling of `start_cluster` and `v2_size_threshold`. - Update choose_v2_level_block and its call in hierarchical_projection.py. - Expose new_points_cluster_assignments: (M, L) int | None after transform().
Auto-applied locally to satisfy CI (matches pre-commit in CI).
Collaborator
Author
Owner
|
@ssarfraz, done, 2.0.1 is in pypi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What’s in this PR
start_clusterandv2_size_threshold.choose_v2_level_blockand its call inhierarchical_projection.py.new_points_cluster_assignments: (M, L) int | Nonereturned aftertransform(new_points).Important context
devwas fully synchronized withmainbefore these changes. We resetdevto matchmain(commit 349c32f “Update the docs.”), so there’s no lingering drift from older work.dev(with the older commits) is preserved as a backup branch:dev_backup_20251110_155055. If anything needs to be recovered, it’s safe there.safe to merge
devwas aligned withmainfirst, this PR contains only the new, focused changes listed above.mainaside from the intended fixes/features.Reviewer checklist
transform()return.Post-merge: publish to PyPI
After merging to
main, I have bumped the package version in setup to 2.0.1, please check and and publish: