Update finch_clustering.py when using initial_rank#31
Merged
Conversation
Updating the initial_rank initialization to avoid shape error when ensure_early_exit is TRUE
Owner
|
Thanks a lot for the contribution @rdevaux309 😃 I apologize for the really long reply time on this one, a lot of deadlines one after another 😅 We are actually working one some updates on the whole algorithm to make the visualization nicer, so stay tuned 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple change to avoid an error when using an
initial_rankin input (see my Issue for more details) :)