Skip to content

chore: use upstream update automation#911

Merged
mbevc1 merged 2 commits into
mainfrom
20260526_remove_manual_homebrew
May 27, 2026
Merged

chore: use upstream update automation#911
mbevc1 merged 2 commits into
mainfrom
20260526_remove_manual_homebrew

Conversation

@mbevc1
Copy link
Copy Markdown
Contributor

@mbevc1 mbevc1 commented May 26, 2026

mislav/bump-homebrew-formula-action@v4 GHA is currently broken due GH endpoint http reposnse changes. We use upstream automatic updating now and shouldn't try to manually publish: Homebrew/homebrew-core#284321

@mbevc1 mbevc1 added enhancement New feature or request github-actions labels May 26, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 26, 2026

Claude finished @mbevc1's task in 1m 33s —— View job


Review: Remove manual Homebrew formula bump from release workflow

  • Run static analysis (go build, go vet, go mod tidy)
  • Review the diff
  • Post review findings

Static Analysis

All checks pass cleanly — go build ./..., go vet ./..., and go mod tidy report no issues. This is expected since the change is workflow-only.

Code Review

The change looks correct and clean. Two commits that:

  1. Remove the homebrew-pr job (the mislav/bump-homebrew-formula-action@v4 step + harden runner + env config) — 18 lines
  2. Remove homebrew-pr from the notify-finish job's needs list — 1 line + trailing comma fix

Verified no dangling references: After this PR, no remaining references to homebrew-pr or COMMITTER_TOKEN exist in any workflow file. The other homebrew references in install-script-tests.yml are unrelated (they test Homebrew installation, not formula publishing).

No issues found:

  • The notify-finish needs array is correctly updated — homebrew-pr is removed and the remaining entries are properly formatted
  • No jobs depended on homebrew-pr other than notify-finish, so the dependency graph is intact
  • The rationale is sound: upstream Homebrew autobump (homebrew-core#284321) handles this, and the action is broken anyway

Housekeeping Note

The COMMITTER_TOKEN secret is no longer referenced anywhere in workflows after this change. You may want to remove it from the repo's GitHub Secrets as cleanup.

LGTM — straightforward, well-scoped removal. Nice cleanup.

@mbevc1 mbevc1 enabled auto-merge (squash) May 26, 2026 21:58
@mbevc1 mbevc1 merged commit f3893e1 into main May 27, 2026
20 checks passed
@mbevc1 mbevc1 deleted the 20260526_remove_manual_homebrew branch May 27, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request github-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants