Skip to content

fix: specify custom attestation type#910

Merged
mbevc1 merged 1 commit into
mainfrom
20260526_fix_attestation_type
May 27, 2026
Merged

fix: specify custom attestation type#910
mbevc1 merged 1 commit into
mainfrom
20260526_fix_attestation_type

Conversation

@mbevc1
Copy link
Copy Markdown
Contributor

@mbevc1 mbevc1 commented May 26, 2026

Previous PR #891 didn't provide custom attestation type (https://github.com/kosli-dev/cli/pull/891/changes#diff-ec60bba356baa9a1db241eb6796050a8c987897efa9784975f6a9174085eb1d9R17) in the Flow template. This is fixing this 🚀

@mbevc1 mbevc1 added bug Something isn't working attestations labels May 26, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 26, 2026

Claude finished @mbevc1's task in 1m 37s —— View job


PR Review: fix: specify custom attestation type

  • Gather context and read changed files
  • Run static analysis checks
  • Review code changes
  • Post review summary

Static Analysis

All checks pass — go build, go vet, and go mod tidy report no issues. (This is a YAML-only change, so expected.)

Review

The fix is correct. The custom attestation type requires the custom:<name> format — bare custom is not a valid type. This is confirmed by the attestation reporting code in cmd/kosli/attestCustom.go:194 and the test cases in attestCustom_test.go, which all use the custom:<name> pattern (e.g., custom:person).

The change from type: customtype: custom:four-eyes-result on line 17 of main-flow-template.yml correctly matches the attestation name on line 16.

No issues found. This is a minimal, targeted fix for a real bug introduced in #891.


LGTM — straightforward one-line fix, no concerns. 👍

@mbevc1 mbevc1 enabled auto-merge (squash) May 26, 2026 21:37
Comment thread main-flow-template.yml
@mbevc1 mbevc1 force-pushed the 20260526_fix_attestation_type branch from 459cf8c to 0f00b8f Compare May 26, 2026 21:42
@mbevc1 mbevc1 changed the title fix: specify customer attestation type fix: specify custom attestation type May 26, 2026
@mbevc1 mbevc1 merged commit fa6c154 into main May 27, 2026
20 checks passed
@mbevc1 mbevc1 deleted the 20260526_fix_attestation_type branch May 27, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attestations bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants