You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All checks pass — go build, go vet, and go mod tidy report no issues. (This is a YAML-only change, so expected.)
Review
The fix is correct. The custom attestation type requires the custom:<name> format — bare custom is not a valid type. This is confirmed by the attestation reporting code in cmd/kosli/attestCustom.go:194 and the test cases in attestCustom_test.go, which all use the custom:<name> pattern (e.g., custom:person).
The change from type: custom → type: custom:four-eyes-result on line 17 of main-flow-template.yml correctly matches the attestation name on line 16.
No issues found. This is a minimal, targeted fix for a real bug introduced in #891.
LGTM — straightforward one-line fix, no concerns. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR #891 didn't provide custom attestation type (https://github.com/kosli-dev/cli/pull/891/changes#diff-ec60bba356baa9a1db241eb6796050a8c987897efa9784975f6a9174085eb1d9R17) in the Flow template. This is fixing this 🚀